Fix some flaky tests#4113
Merged
sougou merged 4 commits intovitessio:masterfrom Jul 30, 2018
sougou:flakes
Merged
Conversation
The endtoend test was failing in mariadb because the error message returned was different. The operation has now been changed to something that returns the same message for all flavors. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
There was a race between releasing and acquiring a sema. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
The test was flaky because frequent restarts of mysql were causing the relay log to go corrupt. Changed the my.cnf settings to be more crash-safe. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
update_test was sometimes flaky if replicas were slow. Changed some checks to accommodate this. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
demmer
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mariadb flavor
The endtoend test was failing in mariadb because the error message
returned was different. The operation has now been changed
to something that returns the same message for all flavors.
buffer_test
There was a race between releasing and acquiring a sema.
vtgatev2_test
The test was flaky because frequent restarts of mysql were
causing the relay log to go corrupt. Changed the my.cnf settings
to be more crash-safe.
update_stream
update_test was sometimes flaky if replicas were slow.
Changed some checks to accommodate this.