make the query log timestamps more parseable#4096
Merged
sougou merged 2 commits intovitessio:masterfrom Jul 20, 2018
Merged
Conversation
Change how dates are formatted in the vtgate / vttablet query logs from using time.StampMicro to a custom format with a fixed format for the date part. This way the resulting timestamps include the year and have a consistent number of characters for the day using a leading zero rather than a leading space for single-digit dates. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Contributor
|
Looks like more tests need fixing. |
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Member
Author
|
@sougou fixed |
sougou
approved these changes
Jul 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how dates are formatted in the vtgate / vttablet query logs from using time.StampMicro to a custom format with a fixed format for the date part.
This way the resulting timestamps include the year and have a consistent number of characters for the day using a leading zero rather than a leading space for single-digit dates.
Note that I considered using the builtin
RFC3339Nanoformat, but it doesn't include a fixed number of digits for the decimal part and has an inconsistent format for the timezone, so I opted for this smaller change to just the date part.