vtgate: fix panic on 'analyze table'#4090
Merged
sougou merged 1 commit intovitessio:masterfrom Jul 18, 2018
sougou:panic
Merged
vtgate: fix panic on 'analyze table'#4090sougou merged 1 commit intovitessio:masterfrom sougou:panic
sougou merged 1 commit intovitessio:masterfrom
sougou:panic
Conversation
analyze table was categorized as a DDL in order to store the table name. However, vttablet code was not expecting fields to be returned on DDL execution. This caused it to return a result with valid rows, but empty fields, which caused vtgate to crash. I've now changed DDL statements to also return fields. For good measure, I've also changed DMLs to return fields, because there's no harm. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
acharis
approved these changes
Jul 18, 2018
Contributor
|
wondering if there are any uses of txFetch or execSQL that still pass in false. if not, then maybe we should just elide that param. if we want to keep it, then this LGTM. |
Contributor
Author
|
execSQL has use cases that use false, but probably not the case with txFetch. But it's no big deal to keep the flag explicit, in case it's needed in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analyze table was categorized as a DDL in order to store the table
name. However, vttablet code was not expecting fields to be returned
on DDL execution. This caused it to return a result with valid rows,
but empty fields, which caused vtgate to crash.
I've now changed DDL statements to also return fields. For good
measure, I've also changed DMLs to return fields, because there's
no harm.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com