sqlparser: add StrictDDL variant of ParseNext#4082
Merged
sougou merged 1 commit intovitessio:masterfrom Jul 12, 2018
dt:strict
Merged
sqlparser: add StrictDDL variant of ParseNext#4082sougou merged 1 commit intovitessio:masterfrom dt:strict
sougou merged 1 commit intovitessio:masterfrom
dt:strict
Conversation
dt
changed the title
sougou
reviewed
Jul 12, 2018
go/vt/sqlparser/ast.go
Outdated
Contributor
There was a problem hiding this comment.
Thanks for the change. Could you also add a test for this functionality?
Contributor
Author
There was a problem hiding this comment.
whoops, yes, added a test. Thanks!
This mirrors the `StrictDDL` variant of `Parse` allowing callers using `ParseNext` to also opt into strict handling of DDLs. Signed-off-by: David Taylor <tinystatemachine@gmail.com>
sougou
approved these changes
Jul 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors the
StrictDDLvariant ofParseallowing callers usingParseNextto also opt into strict handling of DDLs.