Skip to content

Updgrade protobuf and grpc versions#4077

Closed
rafael wants to merge 1 commit intovitessio:masterfrom
tinyspeck:updagre-protobuf-and-grpc
Closed

Updgrade protobuf and grpc versions#4077
rafael wants to merge 1 commit intovitessio:masterfrom
tinyspeck:updagre-protobuf-and-grpc

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Jul 10, 2018

Description

Tests

  • I tested this change in our env, couldn't find any regression related to this change.

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael force-pushed the updagre-protobuf-and-grpc branch from 4eaae69 to 5ce45c5 Compare July 10, 2018 22:16
@sougou
Copy link
Copy Markdown
Contributor

sougou commented Jul 11, 2018

@dweitzman already has a PR for 1.1.0 #4010. And he's generated the new files. But I need to push new builds to hub, which will unbreak his PR, but break everyone else until they rebase afterwards. So, I've been hesitant. Maybe I'll do it this weekend.

@rafael
Copy link
Copy Markdown
Member Author

rafael commented Jul 11, 2018

Oh I see. I close this one in favor of #4010 and open a new one just with the gRPC upgrade then.

@rafael rafael closed this Jul 11, 2018
@rafael rafael deleted the updagre-protobuf-and-grpc branch July 11, 2018 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants