replication: don't auto-fix#4019
Closed
sougou wants to merge 2 commits intovitessio:masterfrom
sougou:replication
Closed
replication: don't auto-fix#4019sougou wants to merge 2 commits intovitessio:masterfrom sougou:replication
sougou wants to merge 2 commits intovitessio:masterfrom
sougou:replication
Conversation
Autofixing replication during health check causes dangerous races with the Orchestrator. Until we find a better workflow, it's better to make this something that requires human intervention. As reference, this is the PR that added the feature: ebcb5b3 One possible behavioral change to note is the case of a mysqld restart. In such cases, the replication reporter would have auto-fixed a replica to point at the master. With this change, the restarter script will have to do this explicitly. The ReparentTablet command can be used to fix a stopped replication. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
reparent.py tests if replication gets automatically fixed if mysqld restarts underneath. No, it has to explicitly fix the replication and see if that works. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
|
If you look at my test fix on reparent.py, that clearly shows the downside of this change: if a mysqld is restarted underneath vttablet, it won't be automatically pointed to the master. In fact, it takes two commands: We could look at adding a flag to |
Contributor
|
i would thumbs up a combined |
Contributor
Author
|
Closing this in favor of #4024 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autofixing replication during health check causes dangerous races
with the Orchestrator. Until we find a better workflow, it's better
to make this something that requires human intervention.
As reference, this is the PR that added the feature:
ebcb5b3
One possible behavioral change to note is the case of a mysqld restart.
In such cases, the replication reporter would have auto-fixed a
replica to point at the master. With this change, the restarter
script will have to do this explicitly.
The ReparentTablet command can be used to fix a stopped replication.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com