v3: support database() function#3998
Merged
sougou merged 1 commit intovitessio:masterfrom Jun 8, 2018
sougou:selectdb
Merged
Conversation
Fixes #3954 This is an alternate PR to #3962. The implementation is less efficient, but more correct. This allows you to use the database() call anywherei in the sql, and v3 will substitute it to the actual target string. If necessary, we can add an optimization that won't send the query to the vttablets. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
|
@tirsen to review |
tirsen
approved these changes
Jun 5, 2018
| return false, errors.New("unsupported: LAST_INSERT_ID is only allowed for unsharded keyspaces") | ||
| } | ||
| case node.Name.EqualString("database"): | ||
| expr = sqlparser.ReplaceExpr(expr, node, sqlparser.NewStrVal([]byte(pb.vschema.TargetString()))) |
Collaborator
There was a problem hiding this comment.
vschema contains the current target in the session? 0_o
|
|
||
| // TargetString returns the current TargetString of the session. | ||
| func (vc *vcursorImpl) TargetString() string { | ||
| return vc.safeSession.TargetString |
Collaborator
|
Which vttablet is this sent to? We don't need to optimize around that if it's too much hassle. We don't use it that frequently. |
Contributor
Author
|
it's sent to the 'first' keyspace. There's some algorithm that decides which is the first one. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3954
This is an alternate PR to #3962. The implementation is less
efficient, but more correct. This allows you to use the
database() call anywherei in the sql, and v3 will substitute
it to the actual target string.
If necessary, we can add an optimization that won't send the
query to the vttablets.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com