JDBC version change for 2.2 release#3946
Merged
sougou merged 1 commit intovitessio:masterfrom May 18, 2018
harshit-gangal:java-version-2.2
Merged
JDBC version change for 2.2 release#3946sougou merged 1 commit intovitessio:masterfrom harshit-gangal:java-version-2.2
sougou merged 1 commit intovitessio:masterfrom
harshit-gangal:java-version-2.2
Conversation
Signed-off-by: Harshit Gangal <harshit.gangal@gmail.com>
sougou
approved these changes
May 18, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
hah. we're donwgrading :)
Contributor
|
btw: The -SNAPSHOT version in the pom.xml on the master branch is not relevant for the release. That's because as part of https://vitess.io/internal/release-instructions/#java-packages you need to change (and commit) it on the release branch anyway. Then, after the release you point it to the next planned version, see: https://vitess.io/internal/release-instructions/#bump-java-snapshot-version In this case, the next version is 3.0, so the pom.xml files could have just stayed as they are in the master branch. |
Member
Author
|
Yes. I will bump it to 3.0 after release. Just so that 2.2 is not yet released and I wanted to change the Java Driver version to 2.2, changed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harshit Gangal harshit.gangal@gmail.com