Skip to content

Adding AllowUnsafeDMLs in vttablet configuration#3941

Merged
sougou merged 1 commit intovitessio:masterfrom
adefilippo83:allowdml
Nov 5, 2018
Merged

Adding AllowUnsafeDMLs in vttablet configuration#3941
sougou merged 1 commit intovitessio:masterfrom
adefilippo83:allowdml

Conversation

@adefilippo83
Copy link
Copy Markdown

Signed-off-by: Alessandro De Filippo alessandro@defilippo.me

@adefilippo83 adefilippo83 force-pushed the allowdml branch 3 times, most recently from 70a2653 to fa08761 Compare May 17, 2018 15:47
@adefilippo83 adefilippo83 changed the title Adding AllowUnsafeDMLs as option in vttablet config file Adding AllowUnsafeDMLs as vttablet parameter May 17, 2018
@adefilippo83 adefilippo83 changed the title Adding AllowUnsafeDMLs as vttablet parameter Adding AllowUnsafeDMLs in vttablet configuration May 17, 2018
Copy link
Copy Markdown
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demmer what do you think about PassthroughDMLs also acting as AllowUnsafeDMLs. Is there a situation where we'd want to separate the two?

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Oct 28, 2018

Can you rebase this and get tests to pass?

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Nov 4, 2018

@adefilippo83: Can you rebase this old PR? Let's get this submitted.

@adefilippo83 adefilippo83 force-pushed the allowdml branch 6 times, most recently from 6f8e927 to e7268d1 Compare November 5, 2018 00:05
Signed-off-by: Alessandro De Filippo <alessandro@defilippo.me>
@adefilippo83
Copy link
Copy Markdown
Author

Hi @sougou: I just rebased and squashed. Waiting for tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants