topo: allow cross-cell master calls#3928
Merged
sougou merged 1 commit intovitessio:masterfrom May 14, 2018
sougou:chase_master
Merged
topo: allow cross-cell master calls#3928sougou merged 1 commit intovitessio:masterfrom sougou:chase_master
sougou merged 1 commit intovitessio:masterfrom
sougou:chase_master
Conversation
VTGates are supposed to be able to go cross-cell for master traffic. This ability was lost due to the recent refactor. This change brings back this capability temporarily. The more correct implementation will happen later when the ability to go cross-cell gets implemented more generically for any serving type. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
alainjobart
approved these changes
May 14, 2018
Contributor
alainjobart
left a comment
alainjobart
left a comment
There was a problem hiding this comment.
Yes I think that will work. Thanks for fixing this!
Collaborator
|
This seems like a pretty bad regression to have slipped in unnoticed by the tests... It seems to me we should look into adding multi-cell integration tests into our standard travis pipeline so that issues like this will be caught by the tests in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTGates are supposed to be able to go cross-cell for master traffic.
This ability was lost due to the recent refactor. This change
brings back this capability temporarily.
The more correct implementation will happen later when the ability
to go cross-cell gets implemented more generically for any serving
type.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com