Remove throttled logger that logs unsupported metric types from prometheus backend.#3909
Closed
zmagg wants to merge 1 commit intovitessio:masterfrom
Closed
Remove throttled logger that logs unsupported metric types from prometheus backend.#3909zmagg wants to merge 1 commit intovitessio:masterfrom
zmagg wants to merge 1 commit intovitessio:masterfrom
Conversation
prometheusbackend.go Signed-off-by: Maggie Zhou <mzhou@slack-corp.com>
zmagg
force-pushed
the
prom-unsupport-metrics-removelog
branch
from
41e4c2b to
e6ceaa4
Compare
Contributor
Author
|
/cc @demmer |
Member
|
I think #3901 solves this in a slightly different way -- I also removed the spammy logger but after discussions with @michael-berlin we actually made it a fatal log if any unsupported metric types are registered. This way we will more proactively catch missing implementations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the throttled logger that logs unsupported metric types from the prometheus backend.
These metrics are all intentionally unsupported for now, and if we want to export them later they'll be straightforward to find. This PR removes some unnecessary log spam.