Use an alias so goimports doesn't delete a real import#3886
Merged
michael-berlin merged 1 commit intovitessio:masterfrom May 2, 2018
Merged
Use an alias so goimports doesn't delete a real import#3886michael-berlin merged 1 commit intovitessio:masterfrom
michael-berlin merged 1 commit intovitessio:masterfrom
Conversation
Contributor
michael-berlin
left a comment
michael-berlin
left a comment
There was a problem hiding this comment.
LGTM after comment about "sort" is addressed.
This is indeed a problem. goimports just silently removes the "ldap.v2" import without the alias. Thank you for fixing this :)
go/vt/worker/vertical_split_diff.go
Outdated
Contributor
There was a problem hiding this comment.
I didn't know that this passes the linter now. It seems to be a recent change?
My local goimports does the same thing, so that's fine with me :)
go/vt/worker/split_diff.go
Outdated
Contributor
There was a problem hiding this comment.
nit: Can you please add it to the first group above i.e. next to "sync"?
Thanks!
goimports gets confused by dashes and dots in import names. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Collaborator
Author
|
Moved the "sort" import |
michael-berlin
approved these changes
May 2, 2018
Contributor
michael-berlin
left a comment
michael-berlin
left a comment
There was a problem hiding this comment.
I'll merge after tests have passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goimports gets confused by dashes and dots in import names.
Signed-off-by: David Weitzman dweitzman@pinterest.com