Enable Orchestrator maintenance mode during reparents#3859
Merged
sougou merged 1 commit intovitessio:masterfrom May 1, 2018
Merged
Enable Orchestrator maintenance mode during reparents#3859sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
… it when fixing replication on the old master. Signed-off-by: Harrison McGonigal <hmcgonigal@hubspot.com>
sougou
approved these changes
May 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty minor one to address a race I've seen where orchestrator attempts to fail over a cluster that was undergoing a planned reparent.
To prevent this, maintenance mode should be enabled in
DemoteMaster()and disabled when we runsetMasterLocked()on the old master.