Move vtcombo initTabletMap func to vtcombo package#3849
Merged
sougou merged 4 commits intovitessio:masterfrom May 1, 2018
Merged
Move vtcombo initTabletMap func to vtcombo package#3849sougou merged 4 commits intovitessio:masterfrom
sougou merged 4 commits intovitessio:masterfrom
Conversation
arthurnn
force-pushed
the
arthurnn/vtcombo_mv
branch
from
2e73d88 to
34c409a
Compare
The idea is so another commands can reuse the initTabletMap. In my case, I am building a new command and importing libs from vitess. In my cmd I am faking a topology(using memory) and starting vttablets for it. Similar on what vtcombo does. Signed-off-by: Arthur Neves <arthurnn@gmail.com>
arthurnn
force-pushed
the
arthurnn/vtcombo_mv
branch
from
34c409a to
74ce7e2
Compare
alainjobart
approved these changes
Apr 19, 2018
Contributor
Author
|
ping @sougou |
Contributor
|
Looks like you need to resolve a merge conflict and a code climate issue. |
Signed-off-by: Arthur Neves <arthurnn@gmail.com>
Signed-off-by: Arthur Neves <arthurnn@gmail.com>
Signed-off-by: Arthur Neves <arthurnn@gmail.com>
Contributor
Author
|
@sougou i fixed the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is so other commands can reuse the initTabletMap.
In my case, I am building a new command and importing libs from vitess. In my cmd I am
faking a topology(using memory) and starting vttablets for it. Similar on what vtcombo
does.
With the vtcombo package I can just use that function and not have it copy it over.
cc @sougou @alainjobart