fix data race in vtexplain implementation of ExecuteBatch#3831
Merged
demmer merged 2 commits intovitessio:masterfrom Apr 13, 2018
Merged
fix data race in vtexplain implementation of ExecuteBatch#3831demmer merged 2 commits intovitessio:masterfrom
demmer merged 2 commits intovitessio:masterfrom
Conversation
To prevent concurrent access to the BindVariables map, vtexplain needs to copy the map when simulating RPCs from the vtgate to the vttablet. Fix a bug where the ExecuteBatch implementation didn't do this quite right which caused a data race. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
sougou
reviewed
Apr 12, 2018
| // copy the bindVars into the executor to avoid a data race. | ||
| for _, query := range queries { | ||
| bindVariables := sqltypes.CopyBindVariables(query.BindVariables) | ||
| query.BindVariables = bindVariables |
Contributor
There was a problem hiding this comment.
query.BindVariables = sqltypes.CopyBindVariables(query.BindVariables)
Go guarantees this is safe.
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
sougou
approved these changes
Apr 12, 2018
Member
Author
|
Travis failures are unrelated -- merging in spite of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent concurrent access to the BindVariables map, vtexplain
needs to copy the map when simulating RPCs from the vtgate to the
vttablet.
Fix a bug where the ExecuteBatch implementation didn't do this
quite right which caused a data race.