parser: replace sub-expression feature#3813
Merged
sougou merged 1 commit intovitessio:masterfrom Apr 11, 2018
sougou:subquery
Merged
parser: replace sub-expression feature#3813sougou merged 1 commit intovitessio:masterfrom sougou:subquery
sougou merged 1 commit intovitessio:masterfrom
sougou:subquery
Conversation
In order to swap subqueries with bind values, we need the ability to replace any sub-expression of an expression with another. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
|
This LGTM. I think it will be good if @demmer takes an extra pass at this. |
rafael
approved these changes
Apr 11, 2018
Contributor
Author
|
I'll proactively submit because 2 more PRs depend on this. We can fix forward as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to swap subqueries with bind values, we need
the ability to replace any sub-expression of an
expression with another.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com