parser: improved handling of SET#3777
Merged
sougou merged 1 commit intovitessio:masterfrom Mar 23, 2018
sougou:betterset
Merged
parser: improved handling of SET#3777sougou merged 1 commit intovitessio:masterfrom sougou:betterset
sougou merged 1 commit intovitessio:masterfrom
sougou:betterset
Conversation
Contributor
Author
|
@arthurnn FYI |
bbeaudreault
approved these changes
Mar 23, 2018
Contributor
bbeaudreault
left a comment
bbeaudreault
left a comment
There was a problem hiding this comment.
this is what i was thinking as well, lgtm! Probably want a couple tests for the issue at hand though: comma-separated set commands
This change improves the handling of constructs like SET NAMES and SET CHARSET. It allows intermixing of these with other assignments. VTGate and mysqlproxy have been correspondingly updated. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
|
Oh. Good point. Test added. |
Contributor
|
Sweet! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the handling of constructs like
SET NAMES and SET CHARSET. It allows intermixing of
these with other assignments.
VTGate and mysqlproxy have been correspondingly updated.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com