Skip to content

Change parser to allow SET SQL_AUTO_IS_NULL=0, NAMES utf8 #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arthurnn wants to merge 1 commit into from
Closed

Change parser to allow SET SQL_AUTO_IS_NULL=0, NAMES utf8 #3776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,9 @@ var (
}, {
input: "set charset default",
output: "set ",
}, {
Copy link
Copy Markdown
Member

@demmer demmer Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to modify Set.Format to print both the Exprs and the charset (if non-null) so that this test (and all the ones above it) would more clearly show that the parser is preserving the charset.
https://github.com/tinyspeck/vitess/blame/master/go/vt/sqlparser/ast.go#L579-L587

input: "set wait_timeout = 3600, names 'utf8'",
output: "set wait_timeout = 3600",
}, {
input: "set session wait_timeout = 3600",
output: "set session wait_timeout = 3600",
Expand Down
Loading