Skip to content

add support for USING <identifier> to CREATE TABLE#3633

Merged
alainjobart merged 1 commit intovitessio:masterfrom
tinyspeck:create-table-support-index-using-opt
Feb 7, 2018
Merged

add support for USING <identifier> to CREATE TABLE#3633
alainjobart merged 1 commit intovitessio:masterfrom
tinyspeck:create-table-support-index-using-opt

Conversation

@demmer
Copy link
Copy Markdown
Member

@demmer demmer commented Feb 6, 2018

We noticed that CREATE TABLE isn't parsing an index definition that includes USING BTREE.

Addressed with a simple change to the grammar leveraging an already existing rule that is part of CREATE INDEX.

@demmer demmer requested a review from sougou February 6, 2018 20:22
@sougou
Copy link
Copy Markdown
Contributor

sougou commented Feb 7, 2018

LGTM

Approved with PullApprove

@alainjobart alainjobart merged commit 3f258c5 into vitessio:master Feb 7, 2018
@rafael rafael deleted the create-table-support-index-using-opt branch February 7, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants