Skip to content

Wait for mysqld to be up before attempting restore.#3624

Merged
enisoc merged 1 commit intovitessio:masterfrom
enisoc:mysqld-wait
Feb 3, 2018
Merged

Wait for mysqld to be up before attempting restore.#3624
enisoc merged 1 commit intovitessio:masterfrom
enisoc:mysqld-wait

Conversation

@enisoc
Copy link
Copy Markdown
Member

@enisoc enisoc commented Feb 3, 2018

This avoids crash-looping when starting vttablet and mysqld simultaneously.

Fixes #2397.

cc @derekperkins

This avoids crash-looping when starting vttablet and mysqld
simultaneously.
@derekperkins
Copy link
Copy Markdown
Member

This looks great. Does this solve the problem completely or should we reconfigure the InitContainer to use the init-config option from #3530?

@enisoc
Copy link
Copy Markdown
Member Author

enisoc commented Feb 3, 2018

I think we'll still need to somehow wait for my.cnf to be generated. I'm concerned that using init_config in an init container implies that we have to keep the env vars and mounted config files in sync between that init container and the mysqlctld container, or else they will generate different things.

If we instead make mysqlctld the only thing that ever generates my.cnf, we can have a single source of truth. We just need to make vttablet wait gracefully for my.cnf to show up, like this PR does for mysql.sock.

@alainjobart
Copy link
Copy Markdown
Contributor

alainjobart commented Feb 3, 2018

LGTM

Approved with PullApprove

@enisoc enisoc merged commit ca018c7 into vitessio:master Feb 3, 2018
@enisoc enisoc deleted the mysqld-wait branch February 3, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants