helm: pass in config.backup to backup-flags#3619
Merged
enisoc merged 3 commits intovitessio:masterfrom Feb 3, 2018
Merged
Conversation
Member
|
Now I'm getting |
Member
Author
|
I just pushed a fix that only uses the |
enisoc
reviewed
Feb 3, 2018
helm/vitess/templates/_vttablet.tpl
Outdated
derekperkins
force-pushed
the
vtctld-backup-flags
branch
from
37a006b to
746d642
Compare
Member
Author
|
Good catch on my copy/paste error. I just amended that last commit. |
enisoc
reviewed
Feb 3, 2018
helm/vitess/templates/_helpers.tpl
Outdated
| # backup flags - expects config.backup | ||
| ############################# | ||
| {{- define "backup-flags" -}} | ||
| # set tuple values to more recognizable variables |
Member
There was a problem hiding this comment.
The flag comment strikes again. This is getting injected into the command line, hiding everything after.
Member
Author
There was a problem hiding this comment.
I hate the flag comment!
Member
Author
|
Flag comment destroyed |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@enisoc