Skip to content

helm: add support for PMM#3598

Merged
enisoc merged 4 commits intovitessio:masterfrom
derekperkins:pmm
Feb 2, 2018
Merged

helm: add support for PMM#3598
enisoc merged 4 commits intovitessio:masterfrom
derekperkins:pmm

Conversation

@derekperkins
Copy link
Copy Markdown
Member

This adds optional support to auto-deploy PMM as a separate StatefulSet in Kubernetes, plus adds a pmm-client container to vttablet, along with 2 log tailing containers, which auto-register with the server. It enables mysql metrics and query analytics by default.

The PMM client requires root privileges in the container, so I was forced to remove runAsNonRoot from the default Pod Security Context, but all other containers are still running as a non-root user, so it shouldn't be an issue.

@derekperkins
Copy link
Copy Markdown
Member Author

Also of note, I'm ignoring client errors until https://jira.percona.com/projects/PMM/issues/PMM-1985 is resolved. The client works, and worst case scenario where we ignore an error, it won't have any impact on actual Vitess/MySQL operations.

@enisoc This is ready for review

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put all these RUN commands into script file, and just COPY and RUN that. Currently since these are separate layers, we're still paying for the storage of all the removed files.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I can do that

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they not have an apt repo we can add?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do. This seemed easier, but I can switch to their apt setup

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird to install a systemd service in a container. Can we not just run the server directly?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their whole setup is very opinionated and there isn't a way around this. You have to use their pmm-admin client and it doesn't have an option to run another way.

@derekperkins
Copy link
Copy Markdown
Member Author

I batched all the RUN commands together and it brought the image size from 72 MB down to 45 MB, so that was a win. Is there a reason using the apt repo is better than just grabbing the binary?

@enisoc
Copy link
Copy Markdown
Member

enisoc commented Feb 2, 2018

LGTM

Approved with PullApprove

@enisoc enisoc merged commit 5aef3c1 into vitessio:master Feb 2, 2018
@derekperkins derekperkins deleted the pmm branch March 2, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants