ignore mysql-specific comment statements#3576
Merged
sougou merged 1 commit intovitessio:masterfrom Jan 23, 2018
slanning:comment-queries
Merged
ignore mysql-specific comment statements#3576sougou merged 1 commit intovitessio:masterfrom slanning:comment-queries
sougou merged 1 commit intovitessio:masterfrom
slanning:comment-queries
Conversation
This is related to #3520 Also ignore /*!50708 mysql-version-specific */ comments. I'm not sure if it's a good idea. Instead of stripping leading comments, in case it's /*! ... */ we don't strip it, and consider it a new StmtComment statement type. (Not sure if that should be added to ast.go . I didn't.) I assumed this kind of comment was the only thing in the query, so if there's something like "/*! ... */ select ..." it wouldn't work. The handleComment in executor.go basically does nothing, returning &sqltypes.Result{}
Member
|
I think this will help with migrations. I ran into this yesterday when trying to import a default |
Contributor
Author
|
Hopefully. :) I'm not sure if what I did makes it not send the SQL to any vttablets, or if it goes through to all of them by default somehow. I think it doesn't pass it through... So I worry that in that mysqldump case, if the SET commands aren't passed through, it might cause data corruption (wrong time zone, character set). |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #3520
Ignore
/*! mysql-specific */and/*!50708 mysql-version-specific */comments.I'm not sure if it's a good idea. Instead of stripping leading comments,
in case it's
/*! ... */we now don't strip it, and consider it a new StmtComment statement type.(Not sure if that should be added to ast.go . I didn't.)
I assumed this kind of comment was the only thing in the query,
so if there's something like
"/*! ... */ select ..."it wouldn't work.The handleComment in executor.go basically does nothing, returning
&sqltypes.Result{}