Skip to content

Allow columns named 'status'#3575

Merged
sougou merged 1 commit intovitessio:masterfrom
dweitzman:parse_status
Jan 23, 2018
Merged

Allow columns named 'status'#3575
sougou merged 1 commit intovitessio:masterfrom
dweitzman:parse_status

Conversation

@dweitzman
Copy link
Copy Markdown
Collaborator

No description provided.

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Jan 23, 2018

As discussed on slack, this looks good. You need to run make in the sqlparser directory to regenerate sql.go. That should make this build pass.

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Jan 23, 2018

LGTM

Approved with PullApprove

@sougou sougou merged commit fccc652 into vitessio:master Jan 23, 2018
@sougou
Copy link
Copy Markdown
Contributor

sougou commented Jan 23, 2018

Looks like we need to rework this. As @bbeaudreault pointed out in the other PR, this has introduced conflicts in the grammar.

@dweitzman dweitzman deleted the parse_status branch January 25, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants