Fix for refreshing schema after update#3574
Merged
sougou merged 2 commits intovitessio:masterfrom Jan 23, 2018
Merged
Conversation
Member
|
This is likely the cause of #3567 |
Contributor
|
Ouch I'm sorry about that... Looking at the test, we have a test case for this, except the test is broken: can you also change resilient_server_test.go line 239 from 'ks1' to 'ks2', so the value we try to update is actually different? With that test change, it fails, and with your fix, it passes as it should... Thanks! |
demmer
approved these changes
Jan 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think there was a bug introduced in 3539 where after updating a vschema, vtgate is not properly updating it's version of it.
Steps to reproduce
/debug/vschemaand vtgate can't issue queries to that table.After some debugging, I noticed that the callback was always passing nil in the changes and the vschema doesn't get updated.
This PR fixes this and seems to be working as expected. However, not sure if I'm missing something and
nilhere is needed.