show statements grammar rework#3497
Merged
sougou merged 2 commits intovitessio:masterfrom Dec 22, 2017
Merged
Conversation
Instead of the previous hack which accepted any keyword or identifier following SHOW, rework the grammar to explicitly enumerate all the valid keywords but keep a catch-all for identifiers. Also add test cases for all the valid SHOW constructs as well as the test for invalid `SHOW foobar`. I pulled the set of valid statements from: https://dev.mysql.com/doc/refman/5.7/en/show.html
Instead of defining constant strings for the various show statements handled by vtgate, use the newly added sqlparser.KeywordString hook to convert the token back into a string.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the way the grammar handles
SHOWstatements.Instead of the previous hack which accepted any keyword or identifier following SHOW, rework the grammar to explicitly enumerate all the valid keywords but keep a catch-all for identifiers.
Also add test cases for all the valid SHOW constructs as well as the test for invalid
SHOW foobar.I pulled the set of valid statements from:
https://dev.mysql.com/doc/refman/5.7/en/show.html
This is a prerequisite for changes like #3137 or #3459.