Use destination master for comparisons during split clone#3450
Use destination master for comparisons during split clone#3450tirsen wants to merge 1 commit intovitessio:masterfrom
Conversation
tirsen
force-pushed
the
use-dest-master-for-split-clone
branch
from
4a25d61 to
ed9df10
Compare
go/vt/worker/tablet_provider.go
Outdated
There was a problem hiding this comment.
Are there other uses of this?
There was a problem hiding this comment.
Only in split clone.
|
This is probably better operationally, even though it's not optimal for resource usage. So I agree with this change. (note there is one case where the destination master could be in use, it's for a reverse vertical split, where a set of tables are moving back to an existing keyspace that has tables. But it's not a very common case, so this should be ok). |
|
Tests are failing. It's probably related to the min_healthy thing, because there is only one master. |
tirsen
force-pushed
the
use-dest-master-for-split-clone
branch
5 times, most recently
from
9ab76c4 to
2e64c5d
Compare
|
I think the only failure now is that it's flaky. It only happens in the |
|
This failure looks real. |
tirsen
force-pushed
the
use-dest-master-for-split-clone
branch
from
2e64c5d to
deb54e5
Compare
tirsen
requested review from
alainjobart,
bbeaudreault,
demmer,
enisoc and
sougou
as code owners
tirsen
force-pushed
the
use-dest-master-for-split-clone
branch
12 times, most recently
from
7558407 to
d45056b
Compare
This makes us avoid extra rows which can show up due to replication lag if we're using a replica for comparisons. The master of the destination shard should generally not be loaded since it's not yet taking any traffic. Signed-off-by: Jon Tirsen <jontirsen@squareup.com>
tirsen
force-pushed
the
use-dest-master-for-split-clone
branch
from
d45056b to
8e4de93
Compare
|
Can you rebase this and get tests to pass? I think this will also fix @dweitzman's issue: #4284. |
Signed-off-by: deepthi <deepthi@planetscale.com>
…split-clone Rebase #3450 Use destination master for comparison during split clone
|
Merged via #4331. |
5 participants
This makes us avoid extra rows which can show up due to replication lag if we're using a replica for comparisons. The master of the destination shard should generally not be loaded since it's not yet taking any traffic.