Add new makefile target cleanall to remove files pulled down by bootstrap.sh#3411
Add new makefile target cleanall to remove files pulled down by bootstrap.sh#3411sougou merged 2 commits intovitessio:masterfrom
Conversation
…trap.sh This is to completely clean up your working environment without touching anything that's local in the git repo. Reasons for this are when changing the go binaries or wanting to be sure your repo is clean.
|
Maybe |
| # keep the vendor.json file but nothing else under the vendor directory as it's not actually part of the Vitess repo | ||
| rm -rf vendor/cloud.google.com vendor/github.com vendor/golang.org vendor/google.golang.org vendor/gopkg.in | ||
| # other stuff in the go hierarchy that is not under vendor/ | ||
| rm -rf ../../../golang.org ../../../honnef.co |
There was a problem hiding this comment.
We shouldn't remove anything outside the vitess tree because the user may have other projects that depend on those downloads. Same for the line below.
There was a problem hiding this comment.
I'm not removing anything that wasn't created by bootstrap.sh. If someone has added local changes I agree they'll lose them but isn't something like make cleanall intended to do what it says?
There was a problem hiding this comment.
If you want me to be very explicit and check each and every package that's pulled down by bootstrap.sh then I can do that. It's not clear to me what you're trying to prevent or if you just want to be extremely cautious when running such a command.
There was a problem hiding this comment.
I was more worried about such external dependencies being used by other projects. But I guess such people can stay away from using cleanall.
|
LGTM |
3 participants
This is to completely clean up your working environment without touching anything that's local in the git repo. Reasons for this are when changing the go binaries or wanting to be sure your repo and build environment is completely clean.