Moving optional RebuildKeyspace out of tests.#3268
Merged
alainjobart merged 1 commit intovitessio:masterfrom Oct 2, 2017
Merged
Moving optional RebuildKeyspace out of tests.#3268alainjobart merged 1 commit intovitessio:masterfrom
alainjobart merged 1 commit intovitessio:masterfrom
Conversation
vttablet's ActionAgent has three startup methods: 1. real production tablet 2. vtcombo in-memory tablet 3. in-memory test tablet for unit tests The optional RebuildKeyspace when SrvKeyspace doesn't exist only needs to be done in case .1, not 2. and 3. vtcombo does an explicit rebuild after having fully created the keyspace (so we don't need the background intermediate ones that will fail and spam the logs anyway). in-memory tests don't ususally need the SrvKeyspace (and if they do, they could call it).
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vttablet's ActionAgent has three startup methods:
The optional RebuildKeyspace when SrvKeyspace doesn't exist only needs
to be done in case .1, not 2. and 3. vtcombo does an explicit rebuild
after having fully created the keyspace (so we don't need the background
intermediate ones that will fail and spam the logs anyway). in-memory
tests don't ususally need the SrvKeyspace (and if they do, they could
call it).