Merged
Conversation
Change the test options to enable normalization by default. Fix typos in test case strings to use ' not " Add a couple more tests
demmer
force-pushed
the
fix-vtexplain-tests
branch
from
2cff3a3 to
c2234d5
Compare
sougou
approved these changes
Sep 30, 2017
Contributor
|
I'll rebase and retest my change against this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #3262 I took a look at whether the vtexplain tests would be affected by that change.
This caused me to notice that the tests didn't previously normalize by default, and never had a case in which there were duplicate values that would be deduped by the normalizer.
I've updated the tests to address all of the above, which means that this change will conflict with #3262 so one or the other needs to be updated once we merge either.