throttler: client unit test: Register the test server before calling gRPC's Serve().#3261
Merged
michael-berlin merged 1 commit intovitessio:masterfrom Sep 30, 2017
Merged
Conversation
Contributor
|
LGTM thanks for fixing this. |
…gRPC's Serve(). Fixes vitessio#3260. I also clarified in grpc_server.go that we are adhering to this requirement when starting up the binary.
michael-berlin
force-pushed
the
grpcthrottler_fix
branch
from
2e497a0 to
2251b21
Compare
Contributor
Author
|
I missed another occurrence in I also double-checked all other *_test.go files and there we don't have the problem. That means we should be good after this is merged. I'll merge once Travis passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3260.
I also clarified in grpc_server.go that we are adhering to this requirement when starting up the binary.