return a known error code when max rows is exceeded#3159
Merged
sougou merged 1 commit intovitessio:masterfrom Sep 11, 2017
Merged
return a known error code when max rows is exceeded#3159sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
…. bucket as resource_exhausted
Contributor
|
We should find out what error code mysql returns for the max rows setting and mimic that. |
Contributor
Author
|
@sougou I scanned https://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html and I didn't see any error codes that made sense. I don't think mysql sets a limit on this? There is an |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose negative numbers for the vitess error codes so they dont conflict with mysql, but could be easily swayed to choose something else if preferred. There are no pre-existing mysql error codes that really make sense for this.
We could also add another field to SQLError, if that would be preferred.