Skip to content

vttablet: Hot Row Protection: Minor readability improvement. #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-berlin merged 1 commit into from
Aug 29, 2017
Merged

vttablet: Hot Row Protection: Minor readability improvement. #3122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions go/vt/vttablet/tabletserver/txserializer/tx_serializer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,20 +150,19 @@ func (t *TxSerializer) lockLocked(ctx context.Context, key, table string) (bool,
"hot row protection: too many queued transactions (%d >= %d)", t.globalSize, t.maxGlobalQueueSize)
}
}
t.globalSize++

if q.size >= t.maxQueueSize {
if t.dryRun {
queueExceededDryRun.Add(table, 1)
t.logQueueExceededDryRun.Warningf("Would have rejected BeginExecute RPC because there are too many queued transactions (%d >= %d) for the same row (table + WHERE clause: '%v')", q.size, t.maxQueueSize, key)
} else {
// Decrement global queue size again because we return early.
t.globalSize--
queueExceeded.Add(table, 1)
return false, vterrors.Errorf(vtrpcpb.Code_RESOURCE_EXHAUSTED,
"hot row protection: too many queued transactions (%d >= %d) for the same row (table + WHERE clause: '%v')", q.size, t.maxQueueSize, key)
}
}

t.globalSize++
q.size++
q.count++
if q.size > q.max {
Expand Down