index fields by name, original name, and full name#3114
Merged
sougou merged 3 commits intovitessio:masterfrom Sep 30, 2017
Merged
index fields by name, original name, and full name#3114sougou merged 3 commits intovitessio:masterfrom
sougou merged 3 commits intovitessio:masterfrom
Conversation
bbeaudreault
suggested changes
Aug 26, 2017
Contributor
bbeaudreault
left a comment
bbeaudreault
left a comment
There was a problem hiding this comment.
Add some tests for this please
| if (!labelMap.containsKey(columnLabel)) { | ||
| labelMap.put(columnLabel, columnIndex); | ||
| } | ||
| String origName = field.getOrgName(); |
Contributor
There was a problem hiding this comment.
the Field may not have these extra values. This is the case when IncludedFields != ALL. So I would check whether the value is null/empty before doing the extra map work and such. Same goes for both new maps.
added 2 commits
September 25, 2017 22:21
Contributor
Author
|
@sougou @bbeaudreault i got around to adding a test to this, i think we're ready. |
Member
|
Netlify is for automated deployment of vitess.io. We're still working on it, so you can ignore it for now. |
bbeaudreault
approved these changes
Sep 27, 2017
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
like mysql-connector-j does
@bbeaudreault @harshit-gangal