Fix usage of last_insert_id with updates#3108
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 25, 2017
Merged
Conversation
Contributor
|
LGTM |
Contributor
Author
|
Thanks! |
This was referenced Jun 24, 2021
This was referenced Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sougou we have a use case that uses a table as a sequence generator. This should work per https://dev.mysql.com/doc/refman/5.7/en/information-functions.html#function_last-insert-id.
When the app is run against direct mysql it would return the sequence value generated. But against vitess it would always return 0. This is because we were not filling in the InsertId in execDMLPK.
I added a test case and added the 1 line fix. Let me know if you can think of any other tests or issues