allow setting transaction isolation#3102
Merged
sougou merged 3 commits intovitessio:masterfrom Aug 24, 2017
Merged
Conversation
sougou
reviewed
Aug 23, 2017
Contributor
There was a problem hiding this comment.
This should be renamed to querypb "github....
I have a patch you can apply to goimports to do this automatically: https://gist.github.com/sougou/2255bc77bf8eaa45eadcc44f8832514f
Contributor
There was a problem hiding this comment.
I think it's better to use a map[querypb.ExecuteOptions]string here. We could even map it to the full statement, thereby avoiding the Sprintf.
Contributor
Author
|
@sougou fixed, PTAL |
… enforce per-transaction before calling begin
bbeaudreault
force-pushed
the
tx_isolation
branch
from
996bae3 to
92b4436
Compare
Contributor
Author
|
Not sure why |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sougou this is as we discussed -- vttablet enforces by executing
set transaction isolation levelbefore eachBegin, when value is non-default. See https://dev.mysql.com/doc/refman/5.7/en/set-transaction.htmlI think this is all it takes, let me know if you think I missed something.