don't pick up python2 from PYTHONPATH during selenium install#3047
Merged
sougou merged 2 commits intovitessio:masterfrom Sep 4, 2017
slanning:patch-1
Merged
don't pick up python2 from PYTHONPATH during selenium install#3047sougou merged 2 commits intovitessio:masterfrom slanning:patch-1
sougou merged 2 commits intovitessio:masterfrom
slanning:patch-1
Conversation
$ ./bootstrap.sh
...
Installing setuptools, pip, wheel...done.
Traceback (most recent call last):
File "/home/whatever/go/dist/selenium/bin/pip", line 7, in <module>
from pip import main
File "/home/whatever/go/dist/grpc/usr/local/lib/python2.7/site-packages/pip/__init__.py", line 21, in <module>
from pip._vendor.requests.packages.urllib3.exceptions import DependencyWarning
ImportError: No module named 'pip._vendor.requests'
Turned out to be because PYTHONPATH had go/dist/grpc/usr/local/lib/python2.7/site-packages before go/dist/selenium/lib/python3.5/site-packages (3.5 has the missing module).
Setting PYTHONPATH= for that pip install worked for me.
Slightly worried because Alex Charis made some commits about this in February ( f14c058 , 3a5949b ), so maybe I'm just undoing that.
Contributor
|
@acharis can you take a look? |
Contributor
|
@acharis ping |
Contributor
|
@slanning can you add a comment before the line on why we're removing the PYTHONPATH? Essentially what you said on the PR. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$ ./bootstrap.sh
...
Installing setuptools, pip, wheel...done.
Traceback (most recent call last):
File "/home/whatever/go/dist/selenium/bin/pip", line 7, in
from pip import main
File "/home/whatever/go/dist/grpc/usr/local/lib/python2.7/site-packages/pip/init.py", line 21, in
from pip._vendor.requests.packages.urllib3.exceptions import DependencyWarning
ImportError: No module named 'pip._vendor.requests'
Turned out to be because PYTHONPATH had go/dist/grpc/usr/local/lib/python2.7/site-packages before go/dist/selenium/lib/python3.5/site-packages (3.5 has the missing module).
Setting PYTHONPATH= for that pip install worked for me.
Slightly worried because Alex Charis made some commits about this in February ( f14c058 , 3a5949b ), so maybe I'm just undoing that.