types: use PlanValue in vtgate#3011
Merged
sougou merged 3 commits intovitessio:masterfrom Jul 27, 2017
sougou:types
Merged
Conversation
Issue #2919 Insert plan values were stored by row, which are not compatible with the new PlanValue scheme, which requires each PlanValue to store the values of one column each . This change stores the values column-wise, which also serendipitously simplifies the code.
Issue #2919 Converted 'Values' in Route, Generate and Limit from interface{} to PlanValue types. Followed the convention that each PlanValue object represents the value(s) of one column. There is still some transitional code for the vindex glue which will be removed in the next commit.
Issue #2919 The vindex API has been changed to accept sqltype.Value instead of interface. This eliminates many unnecessary validations.
alainjobart
approved these changes
Jul 26, 2017
Contributor
alainjobart
left a comment
alainjobart
left a comment
There was a problem hiding this comment.
This is a big change, but seems safe if it compiles and passes all the tests.
This was referenced Jun 24, 2021
This was referenced Aug 4, 2021
This was referenced Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTGate was slightly trickier than tabletserver, which resulted in three commits:
conditionfield where it stores the routing condition, and later resolves it into theValuesinto the engine's route.With these changes, more functions in sqltypes.Value should be obsolete. The next phase of changes will be the cleanup and tightening of sqltypes.