Skip to content

Bump minimum Go version from 1.7 to 1.8.#2682

Merged
michael-berlin merged 2 commits intovitessio:masterfrom
michael-berlin:go18_bump
Mar 28, 2017
Merged

Bump minimum Go version from 1.7 to 1.8.#2682
michael-berlin merged 2 commits intovitessio:masterfrom
michael-berlin:go18_bump

Conversation

@michael-berlin
Copy link
Copy Markdown
Contributor

No description provided.

@michael-berlin michael-berlin mentioned this pull request Mar 27, 2017
@o1egl
Copy link
Copy Markdown

o1egl commented Mar 27, 2017

I think we should wait for 1.8.x golang/go#19182

@alainjobart
Copy link
Copy Markdown
Contributor

That issue will most likely not apply to us. It seems to be an issue where an Atomic value is incremented in a loop, and the compiler optimizes away some code it shouldn't necessarily take away. We don't really do these gratuitous loops anywhere in our code...

YouTube has been running with 1.8 for a while now, and we look at our variables (most instances of atomic counters are for monitoring), they're fine.

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Mar 27, 2017

We come close here https://github.com/youtube/vitess/blob/master/go/pools/resource_pool.go#L172, but it's a CAS operation that also does other things, which will require the compiler to generate code :).

@michael-berlin michael-berlin merged commit f03eba7 into vitessio:master Mar 28, 2017
@michael-berlin michael-berlin deleted the go18_bump branch March 28, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants