Bump minimum Go version from 1.7 to 1.8.#2682
Merged
michael-berlin merged 2 commits intovitessio:masterfrom Mar 28, 2017
Merged
Bump minimum Go version from 1.7 to 1.8.#2682michael-berlin merged 2 commits intovitessio:masterfrom
michael-berlin merged 2 commits intovitessio:masterfrom
Conversation
Closed
alainjobart
approved these changes
Mar 27, 2017
|
I think we should wait for 1.8.x golang/go#19182 |
Contributor
|
That issue will most likely not apply to us. It seems to be an issue where an Atomic value is incremented in a loop, and the compiler optimizes away some code it shouldn't necessarily take away. We don't really do these gratuitous loops anywhere in our code... YouTube has been running with 1.8 for a while now, and we look at our variables (most instances of atomic counters are for monitoring), they're fine. |
Contributor
|
We come close here https://github.com/youtube/vitess/blob/master/go/pools/resource_pool.go#L172, but it's a CAS operation that also does other things, which will require the compiler to generate code :). |
cca9c57 to
41aa5e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.