Merged
Conversation
To use an internal data structure (vs the proto structure), so we can get more information from RBR events if available. Filling in the table name when available in RBR event, and using it in table filter.
Extra bonus: it actually passes.
sougou
approved these changes
Mar 15, 2017
| } | ||
| ) | ||
|
|
||
| // FullBinlogStatement has all the information we can gather for an event. |
Contributor
There was a problem hiding this comment.
Will there be a benefit to making this a protobuf?
Contributor
Author
There was a problem hiding this comment.
We agreed offline that is not needed right now, because we won't send this over the network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for all data types.
Really plumb in the schema.Engine inside tabletmanager.
table name is now populated for RBR events, using it for TablesFilter.
this makes vertical splits now work with RBR. Adding a RBR version of the end to end test, and it passes.