proto: Regenerate protobuf files.#2584
Merged
michael-berlin merged 1 commit intovitessio:masterfrom Feb 23, 2017
Merged
Conversation
This is a follow-up fix for vitessio#2495. We were not able to fix Yipei's workstation such that it would use the same protobuf generator as Travis and our setups does. Therefore, I'm re-generating the files separately on my machine.
Contributor
|
Sugu had them in his PR too. Not sure why. |
Contributor
|
LGTM |
Contributor
Author
|
Yipei and I spent quiet some time on this and could not reproduce it :( The The easiest solution for now is to update protoc-gen-go. But it's still worrisome that the pinning doesn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix for #2495.
We were not able to fix Yipei's workstation such that it would use the
same protobuf generator as Travis and our setups does. Therefore, I'm
re-generating the files separately on my machine.