Cipher must be a legal UTF8 string.

[dcadevil]

The cipher generated by vtgate on initial handshake must be a legal UTF8 string. Otherwise, use the vanilla jdbc driver to connect to the vtgate will get a permission error.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[alainjobart]

LGTM thanks for the fix, I missed that from crypt_genhash_impl.cc / generate_user_salt().

[alainjobart]

Not sure how to fix the CLA stuff though...

[michael-berlin]

Please sort out the CLA issue first. Only after that we can merge it :)

Maybe the email in your commit and the primary email of your GitHub account is different? In the past, this has caused problems for us. See https://github.com/youtube/vitess/pull/2583.patch for the email which was used in your commit.

[googlebot]

CLAs look good, thanks!