Merged
Conversation
Member
Author
|
@sougou - Error is fixed now. |
Contributor
|
LGTM This is a good start. We'll likely have to iterate on it over time in the following areas:
|
dispalt
added a commit
to dispalt/vitess
that referenced
this pull request
Jan 9, 2017
* 'master' of https://github.com/youtube/vitess: (220 commits) vtgate/vindexes: Do not run testfiles.Locate() from init() (2nd time). Add comment to document when new fields are included in response publish site Fri Jan 6 08:02:30 PST 2017 Updating doc. Optionally send additional C API fields through in responses Fixing explorer to handle empty files. MultiRow Insert Optimization (vitessio#2422) Now the local examples use 'zk2' topology. Adding Consul 0.7.2 to base docker image. etcd2topo: using lease ID in lock filenames. Implementing the Consul topology client. test: vtgate_buffer.py: Add second test for vtctl TabletExternallyReparented. test: vtgate_buffer.py: Stop the the two threads in case of a test error. test: vtgate_buffer.py: Move setup code from setUp to setUpModule. test: Add "demote_master_commands" to MysqlFlavor class. Include on clauses in impossible queries, to avoid only_full_group_by in aggregations with joins (vitessio#2433) Adds support for parsing queries with boolean value comparisons, i.e. true/false and =, !=, >, <, >=, <= (vitessio#2432) V3 Engine Code Refactor (vitessio#2423) Refactor impossible query generation, and support group by - (vitessio#2409) docker/test/run: Avoid using non-universal --tmpdir flag on mktemp (vitessio#2429) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently I am getting (missing Execute method) errors for the vindexes in route.go
go/vt/vtgate/engine/route.go:601: cannot use vcursor (type VCursor) as type vindexes.VCursor in argument to mapper.Map: VCursor does not implement vindexes.VCursor (missing Execute method)Let me know what I am missing here.
PR is open for more code refactoring proposal.