[release-23.0] vtorc: support analysis ordering, improve semi-sync rollout (#19427)#19472
Merged
timvaillancourt merged 5 commits intorelease-23.0from Mar 5, 2026
Merged
Conversation
vitess-bot
bot
added
Type: Bug
Type: Enhancement
Contributor
Author
|
Hello @timvaillancourt, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace |
vitess-bot
bot
requested review from
arthurschreiber,
nickvanw,
shlomi-noach and
timvaillancourt
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
force-pushed
the
backport-19427-to-release-23.0
branch
from
4bf8bdc to
d770b55
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-23.0 #19472 +/- ##
================================================
+ Coverage 69.44% 69.45% +0.01%
================================================
Files 1606 1607 +1
Lines 214980 215068 +88
================================================
+ Hits 149290 149383 +93
+ Misses 65690 65685 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvaillancourt
approved these changes
Feb 25, 2026
timvaillancourt
force-pushed
the
backport-19427-to-release-23.0
branch
3 times, most recently
from
aa9d1fc to
4b710ab
Compare
timvaillancourt
requested review from
frouioui,
mattlord and
rohit-nayak-ps
as code owners
timvaillancourt
requested review from
dbussink,
derekperkins,
harshit-gangal and
systay
as code owners
github-actions
bot
added
Component: Java
timvaillancourt
force-pushed
the
backport-19427-to-release-23.0
branch
from
4b710ab to
26592d7
Compare
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
5 tasks
…7-to-release-23.0 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
…7-to-release-23.0 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
mhamza15
approved these changes
Mar 5, 2026
The commonTabletArg was initialized at package load time using GetFlagVariantForTests(), which randomly picks dashed or underscored flag names. When running the upgrade/downgrade test against the release-22.0 vttablet binary (which only accepts underscored flags), a dashed pick causes vttablet to exit with "unknown flag". Fix by initializing commonTabletArg in TestMain after the cluster is set up (so VtTabletMajorVersion is known) and using GetFlagVariantForTestsByVersion(), which deterministically returns underscored for v22 and dashed for v23+. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
force-pushed
the
backport-19427-to-release-23.0
branch
from
7229fa2 to
e2e6a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #19427