Skip to content

ci: stop installing etcd twice in some workflows, skip protoc#19332

Merged
timvaillancourt merged 1 commit intovitessio:mainfrom
timvaillancourt:etcd-3.6.x
Feb 9, 2026
Merged

ci: stop installing etcd twice in some workflows, skip protoc#19332
timvaillancourt merged 1 commit intovitessio:mainfrom
timvaillancourt:etcd-3.6.x

Conversation

@timvaillancourt
Copy link
Copy Markdown
Contributor

@timvaillancourt timvaillancourt commented Feb 8, 2026

Description

This PR moves etcd stops installing etcd twice in some workflows. If a workflow uses make tools, it's already installing etcd. The 2 x workflows updated in this PR run make tools 👍

Example:

Run make tools
Sun Feb 8 23:52:57 UTC 2026: Installing dependencies
##local system details...
##platform: Linux target:x86_64 OS: linux-gnu
<<< Installing protoc 21.3 >>>
OK: SHA256 checksum verified for protoc-21.3-linux-x86_64.zip
Archive:  protoc-21.3-linux-x86_64.zip
  inflating: bin/protoc              
  inflating: include/google/protobuf/any.proto  
  inflating: include/google/protobuf/api.proto  
  inflating: include/google/protobuf/compiler/plugin.proto  
  inflating: include/google/protobuf/descriptor.proto  
  inflating: include/google/protobuf/duration.proto  
  inflating: include/google/protobuf/empty.proto  
  inflating: include/google/protobuf/field_mask.proto  
  inflating: include/google/protobuf/source_context.proto  
  inflating: include/google/protobuf/struct.proto  
  inflating: include/google/protobuf/timestamp.proto  
  inflating: include/google/protobuf/type.proto  
  inflating: include/google/protobuf/wrappers.proto  
  inflating: readme.txt              
<<< Installing Zookeeper 3.9.4 >>>
OK: SHA512 checksum verified for /home/ubuntu/_work/vitess/vitess/dist/vt-zookeeper-3.9.4/apache-zookeeper-3.9.4-bin.tar.gz
<<< Installing etcd v3.6.7 >>>
OK: SHA256 checksum verified for etcd-v3.6.7-linux-amd64.tar.gz
<<< Installing Consul 1.11.4 >>>
OK: SHA256 checksum verified for consul_1.11.4_linux_amd64.zip
Archive:  consul_1.11.4_linux_amd64.zip
  inflating: consul                  
bootstrap finished - run 'make build' to compile

As a side effect, the version of etcd is synchronised (we use 3.6.x now)

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@github-actions github-actions Bot added this to the v24.0.0 milestone Feb 8, 2026
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 8, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented Feb 8, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 8, 2026
@timvaillancourt timvaillancourt changed the title ci: add setup-etcd action, sync version with reality ci: stop installing etcd twice in some workflows Feb 8, 2026
@timvaillancourt timvaillancourt marked this pull request as ready for review February 8, 2026 23:56
@timvaillancourt timvaillancourt changed the title ci: stop installing etcd twice in some workflows ci: stop installing etcd twice in some workflows, skip protoc Feb 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.95%. Comparing base (03e5108) to head (235dde9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19332   +/-   ##
=======================================
  Coverage   69.95%   69.95%           
=======================================
  Files        1610     1610           
  Lines      216056   216053    -3     
=======================================
- Hits       151141   151139    -2     
+ Misses      64915    64914    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt merged commit 2615585 into vitessio:main Feb 9, 2026
111 of 112 checks passed
@timvaillancourt timvaillancourt deleted the etcd-3.6.x branch February 9, 2026 21:42
mhamza15 pushed a commit to mhamza15/vitess that referenced this pull request Feb 15, 2026
…itessio#19332)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants