Skip to content

[release-23.0] Add new force flag to DemotePrimary to force a demotion even when blocked on waiting for semi-sync acks (#18714)#19239

Merged
timvaillancourt merged 2 commits intorelease-23.0from
backport-18714-to-release-23.0
Jan 28, 2026
Merged

[release-23.0] Add new force flag to DemotePrimary to force a demotion even when blocked on waiting for semi-sync acks (#18714)#19239
timvaillancourt merged 2 commits intorelease-23.0from
backport-18714-to-release-23.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jan 27, 2026

Description

This is a backport of #18714

@vitess-bot vitess-bot bot added Type: Enhancement Logical improvement (somewhere between a bug and feature) Backport This is a backport Component: TabletManager Skip CI Skip CI actions from running Merge Conflict labels Jan 27, 2026
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jan 27, 2026

Hello @arthurschreiber, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 19239
git reset --hard origin/release-23.0
git cherry-pick -m 1 1f49de43adb033aeda0c5c40519bd55b84eca767

@github-actions github-actions bot added this to the v23.0.1 milestone Jan 27, 2026
@mhamza15 mhamza15 removed Skip CI Skip CI actions from running Merge Conflict labels Jan 27, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 50.87719% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.71%. Comparing base (5321865) to head (c1a8c99).
⚠️ Report is 7 commits behind head on release-23.0.

Files with missing lines Patch % Lines
go/vt/mysqlctl/replication.go 0.00% 15 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go 37.50% 10 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 2 Missing ⚠️
go/vt/vttablet/faketmclient/fake_client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.0   #19239      +/-   ##
================================================
+ Coverage         69.70%   69.71%   +0.01%     
================================================
  Files              1606     1606              
  Lines            214599   214666      +67     
================================================
+ Hits             149590   149662      +72     
+ Misses            65009    65004       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhamza15 mhamza15 marked this pull request as ready for review January 27, 2026 22:20
@timvaillancourt timvaillancourt self-requested a review January 27, 2026 22:58
@timvaillancourt timvaillancourt enabled auto-merge (squash) January 27, 2026 22:58
@timvaillancourt timvaillancourt merged commit 5cb54e2 into release-23.0 Jan 28, 2026
105 of 111 checks passed
@timvaillancourt timvaillancourt deleted the backport-18714-to-release-23.0 branch January 28, 2026 12:47
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…otion even when blocked on waiting for semi-sync acks (vitessio#18714) (vitessio#19239)

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…otion even when blocked on waiting for semi-sync acks (vitessio#18714) (vitessio#19239)

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…otion even when blocked on waiting for semi-sync acks (vitessio#18714) (vitessio#19239)

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…otion even when blocked on waiting for semi-sync acks (vitessio#18714) (vitessio#19239)

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: TabletManager Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants