[release-23.0] Add new force flag to DemotePrimary to force a demotion even when blocked on waiting for semi-sync acks (#18714)#19239
Merged
timvaillancourt merged 2 commits intorelease-23.0from Jan 28, 2026
Conversation
Contributor
Author
|
Hello @arthurschreiber, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace |
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-23.0 #19239 +/- ##
================================================
+ Coverage 69.70% 69.71% +0.01%
================================================
Files 1606 1606
Lines 214599 214666 +67
================================================
+ Hits 149590 149662 +72
+ Misses 65009 65004 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvaillancourt
approved these changes
Jan 27, 2026
arthurschreiber
approved these changes
Jan 28, 2026
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…otion even when blocked on waiting for semi-sync acks (vitessio#18714) (vitessio#19239) Signed-off-by: Mohamed Hamza <mhamza@fastmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…otion even when blocked on waiting for semi-sync acks (vitessio#18714) (vitessio#19239) Signed-off-by: Mohamed Hamza <mhamza@fastmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Mohamed Hamza <mhamza@fastmail.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…otion even when blocked on waiting for semi-sync acks (vitessio#18714) (vitessio#19239) Signed-off-by: Mohamed Hamza <mhamza@fastmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Mohamed Hamza <mhamza@fastmail.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…otion even when blocked on waiting for semi-sync acks (vitessio#18714) (vitessio#19239) Signed-off-by: Mohamed Hamza <mhamza@fastmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Mohamed Hamza <mhamza@fastmail.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #18714