Skip to content

[release-23.0] evalengine: Fix NULL document handling in JSON functions (#19052)#19231

Merged
arthurschreiber merged 1 commit intorelease-23.0from
backport-19052-to-release-23.0
Feb 4, 2026
Merged

[release-23.0] evalengine: Fix NULL document handling in JSON functions (#19052)#19231
arthurschreiber merged 1 commit intorelease-23.0from
backport-19052-to-release-23.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jan 27, 2026

Description

This is a backport of #19052

@vitess-bot vitess-bot bot added Type: Bug Backport This is a backport Component: Evalengine changes to the evaluation engine Skip CI Skip CI actions from running Merge Conflict labels Jan 27, 2026
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jan 27, 2026

Hello @arthurschreiber, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 19231
git reset --hard origin/release-23.0
git cherry-pick -m 1 43ba94b3fb718c3b13db5a792a13c509c73d2b37

@vitess-bot vitess-bot bot added Skip CI Skip CI actions from running Merge Conflict labels Jan 27, 2026
@github-actions github-actions bot added this to the v23.0.1 milestone Jan 27, 2026
@arthurschreiber
Copy link
Member

This depends on #19254 being merged first.

@arthurschreiber arthurschreiber force-pushed the backport-19052-to-release-23.0 branch from 6fb53f0 to 11f081a Compare February 2, 2026 11:48
@arthurschreiber arthurschreiber removed Skip CI Skip CI actions from running Merge Conflict labels Feb 2, 2026
@arthurschreiber arthurschreiber force-pushed the backport-19052-to-release-23.0 branch from 11f081a to 9b0bd5e Compare February 2, 2026 11:49
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber arthurschreiber force-pushed the backport-19052-to-release-23.0 branch from 9b0bd5e to bf3f021 Compare February 2, 2026 11:49
@arthurschreiber arthurschreiber marked this pull request as ready for review February 2, 2026 11:50
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.72%. Comparing base (7282f6a) to head (bf3f021).
⚠️ Report is 2 commits behind head on release-23.0.

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/fn_json.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.0   #19231      +/-   ##
================================================
+ Coverage         69.70%   69.72%   +0.02%     
================================================
  Files              1606     1606              
  Lines            214792   214800       +8     
================================================
+ Hits             149720   149770      +50     
+ Misses            65072    65030      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber arthurschreiber merged commit 4c9eccd into release-23.0 Feb 4, 2026
102 of 108 checks passed
@arthurschreiber arthurschreiber deleted the backport-19052-to-release-23.0 branch February 4, 2026 10:23
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…ions (vitessio#19052) (vitessio#19231)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…ions (vitessio#19052) (vitessio#19231)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…ions (vitessio#19052) (vitessio#19231)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…ions (vitessio#19052) (vitessio#19231)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Evalengine changes to the evaluation engine Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants