Skip to content

[main] Upgrade the Golang version to go1.25.6#19180

Merged
mattlord merged 8 commits intomainfrom
upgrade-go-to-1.25.6-on-main
Jan 22, 2026
Merged

[main] Upgrade the Golang version to go1.25.6#19180
mattlord merged 8 commits intomainfrom
upgrade-go-to-1.25.6-on-main

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot commented Jan 19, 2026

This Pull Request bumps the Golang version to go1.25.6 and the bootstrap version to 50.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are manual steps remaining:

  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that

cc @vitessio/release

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vitess-bot vitess-bot force-pushed the upgrade-go-to-1.25.6-on-main branch from 2262725 to 3ad2035 Compare January 19, 2026 20:32
@vitess-bot vitess-bot added the Benchmark me Add label to PR to run benchmarks label Jan 19, 2026
@vitess-bot vitess-bot requested a review from frouioui as a code owner January 19, 2026 20:32
@vitess-bot vitess-bot added Component: General Changes throughout the code base go labels Jan 19, 2026
@vitess-bot vitess-bot added Skip CI Skip CI actions from running Type: CI/Build labels Jan 19, 2026
@vitess-bot vitess-bot requested a review from a team January 19, 2026 20:32
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 19, 2026

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@github-actions github-actions bot added this to the v24.0.0 milestone Jan 19, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 19, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 19, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@mattlord mattlord removed Skip CI Skip CI actions from running NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 21, 2026
Signed-off-by: Matt Lord <mattalord@gmail.com>
We now use go.mod in the branches for the golang version
to use.

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the upgrade-go-to-1.25.6-on-main branch from 9831078 to 91fa636 Compare January 22, 2026 03:39
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.92%. Comparing base (4a3e6a3) to head (6c1bc98).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19180      +/-   ##
==========================================
+ Coverage   69.91%   69.92%   +0.01%     
==========================================
  Files        1613     1611       -2     
  Lines      216122   216176      +54     
==========================================
+ Hits       151097   151162      +65     
+ Misses      65025    65014      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Matt Lord <mattalord@gmail.com>
…on-main

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the upgrade-go-to-1.25.6-on-main branch from 36a4bfe to 6c1bc98 Compare January 22, 2026 17:02
…on-main

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the upgrade-go-to-1.25.6-on-main branch from 6c1bc98 to 2781c3e Compare January 22, 2026 19:53
@mattlord mattlord enabled auto-merge (squash) January 22, 2026 20:18
@mattlord mattlord merged commit 92235e9 into main Jan 22, 2026
100 of 102 checks passed
@mattlord mattlord deleted the upgrade-go-to-1.25.6-on-main branch January 22, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants