[release-23.0] VDiff: Prevent division by 0 when reconciling mismatches for reference tables (#19160)#19165
Merged
mattlord merged 1 commit intorelease-23.0from Jan 16, 2026
Merged
Conversation
…e tables (#19160) Signed-off-by: Matt Lord <mattalord@gmail.com>
vitess-bot
bot
requested review from
beingnoble03,
mattlord,
rohit-nayak-ps and
shlomi-noach
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mattlord
approved these changes
Jan 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.0 #19165 +/- ##
=============================================
Coverage 69.71% 69.71%
=============================================
Files 1606 1606
Lines 214604 214599 -5
=============================================
- Hits 149606 149603 -3
+ Misses 64998 64996 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…es for reference tables (vitessio#19160) (vitessio#19165) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…es for reference tables (vitessio#19160) (vitessio#19165) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…es for reference tables (vitessio#19160) (vitessio#19165) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Feb 5, 2026
…es for reference tables (vitessio#19160) (vitessio#19165) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Jun Wang <jun.wang@demonware.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #19160