Skip to content

Increase GTID position column size to LONGBLOB for VReplication#19119

Merged
mattlord merged 1 commit intovitessio:mainfrom
slackhq:increase-gtid-column-size
Jan 11, 2026
Merged

Increase GTID position column size to LONGBLOB for VReplication#19119
mattlord merged 1 commit intovitessio:mainfrom
slackhq:increase-gtid-column-size

Conversation

@yushuqin
Copy link
Contributor

@yushuqin yushuqin commented Jan 10, 2026 •
edited by mattlord
Loading

This change increases the size of GTID position columns in VReplication sidecar tables from varbinary(10000) to longblob to prevent "Data too long for column" errors causing vitess onlineddl failures.

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 10, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 10, 2026
@github-actions github-actions bot added this to the v24.0.0 milestone Jan 10, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 10, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@promptless
Copy link
Contributor

promptless bot commented Jan 10, 2026

📝 Documentation updates detected!

New suggestion: Update vreplication-store-compressed-gtid flag documentation

@mattlord mattlord added Type: Bug Component: VReplication and removed NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 10, 2026
@mattlord mattlord self-assigned this Jan 10, 2026
@mattlord mattlord added the Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) label Jan 10, 2026
@codecov
Copy link

codecov bot commented Jan 10, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.87%. Comparing base (fa770f9) to head (ae4f115).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #19119      +/-   ##
==========================================
- Coverage   69.87%   69.87%   -0.01%     
==========================================
  Files        1613     1613              
  Lines      216002   216023      +21     
==========================================
+ Hits       150939   150949      +10     
- Misses      65063    65074      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yushuqin
Increase GTID position column size to LONGBLOB for VReplication
ae4f115 
This change increases the size of GTID position columns in VReplication
sidecar tables from varbinary(10000) to longblob to prevent "Data too
long for column" errors using vitess onlineddl.

Signed-off-by: Yushu Qin <yqin@slack-corp.com>
@yushuqin yushuqin force-pushed the increase-gtid-column-size branch from 2fbb823 to ae4f115 Compare January 10, 2026 22:12
mattlord
mattlord approved these changes Jan 11, 2026
View reviewed changes
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yushuqin!

@mattlord mattlord removed the NeedsIssue A linked issue is missing for this Pull Request label Jan 11, 2026
@mattlord mattlord enabled auto-merge (squash) January 11, 2026 18:59
@mattlord mattlord merged commit fc242ff into vitessio:main Jan 11, 2026
136 of 163 checks passed
yushuqin added a commit to slackhq/vitess that referenced this pull request Jan 12, 2026
@yushuqin
[slack-19.0]: backport: Increase GTID position column size to LONGB…
4d3967d 
…LOB for VReplication (vitessio#19119)

This backport increases the GTID position column size from BLOB to LONGBLOB
in VReplication tables to prevent data truncation for large GTID sets.

Backported from vitessio#19119
Original commit: fc242ff

Changes:
- Update schema_version.sql to use LONGBLOB for pos column
- Update vreplication.sql to use LONGBLOB for pos column
- Add comprehensive test coverage for GTID position handling
- Update schema tests to reflect new column type
yushuqin added a commit to slackhq/vitess that referenced this pull request Jan 12, 2026
@yushuqin
[slack-19.0]: backport: Increase GTID position column size to LONGB…
0eca30e 
…LOB for VReplication (vitessio#19119)

This backport increases the GTID position column size from BLOB to LONGBLOB
in VReplication tables to prevent data truncation for large GTID sets.

Backported from vitessio#19119
Original commit: fc242ff

Changes:
- Update schema_version.sql to use LONGBLOB for pos column
- Update vreplication.sql to use LONGBLOB for pos column
- Update schema tests to reflect new column type

Note: Test file changes from upstream were not included as they depend on
features not present in slack-19.0 branch. Core schema changes are sufficient.
@yushuqin yushuqin mentioned this pull request Jan 12, 2026
Merged
5 tasks
tanjinx pushed a commit to slackhq/vitess that referenced this pull request Jan 13, 2026
@yushuqin
[slack-19.0]: backport: Increase GTID position column size to LONGB…
43cfe4d 
…LOB for VReplication (vitessio#19119) (#770)

This backport increases the GTID position column size from BLOB to LONGBLOB
in VReplication tables to prevent data truncation for large GTID sets.

Backported from vitessio#19119
Original commit: fc242ff

Changes:
- Update schema_version.sql to use LONGBLOB for pos column
- Update vreplication.sql to use LONGBLOB for pos column
- Update schema tests to reflect new column type

Note: Test file changes from upstream were not included as they depend on
features not present in slack-19.0 branch. Core schema changes are sufficient.
@promptless promptless bot mentioned this pull request Jan 20, 2026
Merged
yushuqin added a commit to slackhq/vitess that referenced this pull request Jan 27, 2026
@yushuqin
[slack-19.0]: backport: Increase GTID position column size to LONGB…
ef47fca 
…LOB for VReplication (vitessio#19119) (#770)

This backport increases the GTID position column size from BLOB to LONGBLOB
in VReplication tables to prevent data truncation for large GTID sets.

Backported from vitessio#19119
Original commit: fc242ff

Changes:
- Update schema_version.sql to use LONGBLOB for pos column
- Update vreplication.sql to use LONGBLOB for pos column
- Update schema tests to reflect new column type

Note: Test file changes from upstream were not included as they depend on
features not present in slack-19.0 branch. Core schema changes are sufficient.
@yushuqin yushuqin mentioned this pull request Jan 27, 2026
Merged
5 tasks
tanjinx added a commit to slackhq/vitess that referenced this pull request Jan 27, 2026
@yushuqin @tanjinx
onlineddl v22 backport (#782)
fdd2bc7 
* Fix zero timestamp in vifl (#773)

Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>

* [`slack-19.0`]: backport: Increase GTID position column size to LONGBLOB for VReplication (vitessio#19119) (#770)

This backport increases the GTID position column size from BLOB to LONGBLOB
in VReplication tables to prevent data truncation for large GTID sets.

Backported from vitessio#19119
Original commit: fc242ff

Changes:
- Update schema_version.sql to use LONGBLOB for pos column
- Update vreplication.sql to use LONGBLOB for pos column
- Update schema tests to reflect new column type

Note: Test file changes from upstream were not included as they depend on
features not present in slack-19.0 branch. Core schema changes are sufficient.

* Fix GC table regex for lower case compatibility (#753)

Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com>

---------

Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com>
Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
sbaker617 pushed a commit to slackhq/vitess that referenced this pull request Feb 5, 2026
@yushuqin @tanjinx @sbaker617
onlineddl v22 backport (#782)
3c32b4e 
* Fix zero timestamp in vifl (#773)

Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>

* [`slack-19.0`]: backport: Increase GTID position column size to LONGBLOB for VReplication (vitessio#19119) (#770)

This backport increases the GTID position column size from BLOB to LONGBLOB
in VReplication tables to prevent data truncation for large GTID sets.

Backported from vitessio#19119
Original commit: fc242ff

Changes:
- Update schema_version.sql to use LONGBLOB for pos column
- Update vreplication.sql to use LONGBLOB for pos column
- Update schema tests to reflect new column type

Note: Test file changes from upstream were not included as they depend on
features not present in slack-19.0 branch. Core schema changes are sufficient.

* Fix GC table regex for lower case compatibility (#753)

Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com>

---------

Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com>
Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@nickvanw nickvanw nickvanw approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

Assignees

@mattlord mattlord

Labels

Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: VReplication Type: Bug

Projects

None yet

Milestone

v24.0.0

Development

Successfully merging this pull request may close these issues.

Bug Report: VReplication table GTID position columns size limit is insufficient

3 participants

@yushuqin @mattlord @nickvanw